Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source US Census - Migrate Python CDK to Low-code CDK #43521

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

topefolorunso
Copy link
Collaborator

@topefolorunso topefolorunso commented Aug 10, 2024

What

Migrate US Census Python CDK to Low-code CDK fixes https://github.com/airbytehq/airbyte-internal-issues/issues/9126 and closes #28122

How

Developed using UI Builder and the Low-code CDK

Recommended reading order

  1. manifest.yaml
  2. components.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 4:36am

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Generally, the version of the manifest should match CDK requirement in pyproject.yaml, but it's non-restrictive, so all good.

@natikgadzhi natikgadzhi merged commit 573e8f7 into master Aug 15, 2024
37 checks passed
@natikgadzhi natikgadzhi deleted the tope/migrate-us-census-lowcode branch August 15, 2024 15:33
@natikgadzhi
Copy link
Contributor

This introduced a regression, and we need to fix it — no columns are actually emitted, the streams are empty.

We should also figure out a CAT / live test that would verify that at least one column is present for all streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/us-census
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Source us-census : Migrate Python CDK to Low-code CDK
3 participants