connectors-insights: fix generation for non manifest connector #43430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-09-connectors-insights_fix_generation_for_non_manifest_connector
branch
from
c52fe25 to
e15223d
Compare
alafanechere
force-pushed
the
augustin/08-09-connectors-insights_fix_generation_for_non_manifest_connector
branch
from
e15223d to
c7e9220
Compare
alafanechere
force-pushed
the
augustin/08-09-connectors-insights_fix_generation_for_non_manifest_connector
branch
from
c7e9220 to
3ff6048
Compare
|
Oh noes, did I break it? |
natikgadzhi
approved these changes
Aug 9, 2024
| manifest = connector.manifest_path.read_text() | ||
|
|
||
| schemas_directory = connector.code_path / connector.technical_name.replace("-", "_") / "schemas" | ||
| schemas_directory = connector.code_directory / connector.technical_name.replace("-", "_") / "schemas" |
There was a problem hiding this comment.
Wait up, did I mess it up and it never worked? How did I manage that without failing a test? Or does code_path exist, but does a different thing? What's the difference between them?
alafanechere
deleted the
augustin/08-09-connectors-insights_fix_generation_for_non_manifest_connector
branch
Yes but that's the cost of not writing tests ahah |
LouisAuneau
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Insights generation is broken:
Connector.code_pathattribute does not exists.Connector insights generation now works again.