bulk-cdk: DiscoverOperation supports isResumable #43406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
evantahler
approved these changes
Aug 8, 2024
| @@ -68,6 +67,7 @@ class DiscoverOperation( | |||
| airbyteStream.withSourceDefinedPrimaryKey( | |||
| if (isValidPK) discoveredStream.primaryKeyColumnIDs else listOf(), | |||
| ) | |||
| airbyteStream.isResumable = airbyteStream.sourceDefinedPrimaryKey.isNotEmpty() | |||
There was a problem hiding this comment.
A pleasantly concise change!
There was a problem hiding this comment.
Also not one that will age particularly well; but I prefer to punt rather than anticipating future needs. Conceivably, a stream may not have a PK and yet still be resumable, and vice-versa.
|
CI is failing on integration tests, but nothing alarming. I'll adjust and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for RFR in the Bulk CDK.
Also rename the
MetadataQuerier::primaryKeysmethod toprimaryKey, which I forgot to do in a previous change.Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/9043
How
Update the airbyte-protocol dependency and populate the
isResumableflag in the stream object during a DISCOVER operation.Review guide
User Impact
None
Can this PR be safely reverted and rolled back?