bulk-cdk: complete README #43391
bulk-cdk: complete README #43391
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
|
||
| ## Structure | ||
|
|
||
| The Bulk CDK consists of a _core_ and a bunch of _toolkits_. |
There was a problem hiding this comment.
👍 These terms have really grown on me!
|
|
||
| While BOMs are undoubtedly useful, let's still try to keep external dependencies to a minimum | ||
| outside of tests. | ||
| Less dependencies, less problems. |
There was a problem hiding this comment.
Is there some guidance that we want the lower parts of the CDK to have as few dependencies as possible, but the toolkits can gain deps?
There was a problem hiding this comment.
I don't know about that. Toolkits should also stay slim, in my opinion. Where it matters a lot less is tests, but even so, with gradle when you have a lot of dependencies (and therefore, conflicts) it's super easy to declare depending on version X but really because of a transitive dependency you're using version Y instead, without knowing. Typically what then happens is when you bump the declared dep to a later version Z a whole bunch of unrelated stuff breaks.
| ## Licensing | ||
|
|
||
| The license for the Bulk CDK is Elastic License 2.0, as specified by the LICENSE file in the root | ||
| of this git repository. |
There was a problem hiding this comment.
cc @Hesperide:
I think this is the right license because:
- We do want to allow community members to create fee/OSS connectors using the CDK
- We con't want AWS stealing our code and competing with us
This is a departure from our current CDK license, which is MIT
There was a problem hiding this comment.
Co-authored-by: Evan Tahler <[email protected]>
Co-authored-by: Evan Tahler <[email protected]>
Co-authored-by: Evan Tahler <[email protected]>
What
Complete README for the Bulk CDK.
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/9049
User Impact
None
Can this PR be safely reverted and rolled back?