Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(docs): clarify gcs crednetials configuration for helm chart #43385

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

perangel
Copy link
Contributor

@perangel perangel commented Aug 8, 2024

What

There has been a lot of confusion around providing GCS creds for the log and storage buckets. This cleans up the docs so that we:

  • Instruct users to reference the secret they were instructed to create in the prerequisites section
  • Removes any mention of credentialsPath which is not intended for external use and only leads to confusion.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Summary by CodeRabbit

  • Documentation
    • Updated the implementation guide for configuring Kubernetes secrets for Google Cloud Storage (GCS).
    • Streamlined text by changing the secret name to airbyte-config-secrets.
    • Removed references to credentialsPath for improved clarity in credential management.

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:23pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 8, 2024
Copy link

coderabbitai bot commented Aug 8, 2024

Walkthrough

The documentation has been updated to clarify the configuration of Kubernetes secrets for Google Cloud Storage (GCS). Key changes include the renaming of the default secret from gcp-cred-secrets to airbyte-config-secrets and the removal of references to credentialsPath. These modifications streamline the setup process and align the guidance with current best practices.

Changes

File Path Change Summary
docs/enterprise-setup/...implementation-guide.md Updated secret name from gcp-cred-secrets to airbyte-config-secrets and removed credentialsPath references.

Poem

In the garden where secrets bloom,
The rabbit hops with joyful zoom.
With names now bright and paths made clear,
Kubernetes sings, let’s all give a cheer!
Hooray for change, so fresh and new,
A hop, a skip, we’ll guide you through! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
docs/enterprise-setup/implementation-guide.md (1)

Line range hint 584-590:
Update secret name for GCP configuration.

The secret name gcp-cred-secrets should be updated to airbyte-config-secrets to maintain consistency with the rest of the documentation changes.

-  storageSecretName: gcp-cred-secrets
+  storageSecretName: airbyte-config-secrets
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 99a33cb and 909656a.

Files selected for processing (1)
  • docs/enterprise-setup/implementation-guide.md (1 hunks)
Additional comments not posted (1)
docs/enterprise-setup/implementation-guide.md (1)

359-365: Clarification on GCS configuration looks good.

The updated instructions for configuring GCS, including the new secret name airbyte-config-secrets, are clear and consistent with the intended improvements.

@perangel perangel requested a review from colesnodgrass August 8, 2024 17:45
@perangel perangel merged commit 55c94f9 into master Aug 8, 2024
32 checks passed
@perangel perangel deleted the perangel/docs/improve-gcs-log-config-docs branch August 8, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants