-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(docs): clarify gcs crednetials configuration for helm chart #43385
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe documentation has been updated to clarify the configuration of Kubernetes secrets for Google Cloud Storage (GCS). Key changes include the renaming of the default secret from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
docs/enterprise-setup/implementation-guide.md (1)
Line range hint
584-590
:
Update secret name for GCP configuration.The secret name
gcp-cred-secrets
should be updated toairbyte-config-secrets
to maintain consistency with the rest of the documentation changes.- storageSecretName: gcp-cred-secrets + storageSecretName: airbyte-config-secrets
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/enterprise-setup/implementation-guide.md (1 hunks)
Additional comments not posted (1)
docs/enterprise-setup/implementation-guide.md (1)
359-365
: Clarification on GCS configuration looks good.The updated instructions for configuring GCS, including the new secret name
airbyte-config-secrets
, are clear and consistent with the intended improvements.
What
There has been a lot of confusion around providing GCS creds for the log and storage buckets. This cleans up the docs so that we:
credentialsPath
which is not intended for external use and only leads to confusion.How
Review guide
User Impact
Can this PR be safely reverted and rolled back?
Summary by CodeRabbit
airbyte-config-secrets
.credentialsPath
for improved clarity in credential management.