Destination Snowflake: SqlGenerator class cleanup #43348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
changed the title
...otlin/io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeSqlGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeSqlGenerator.kt
Outdated
Show resolved
Hide resolved
stephane-airbyte
approved these changes
Aug 7, 2024
edgao
approved these changes
Aug 7, 2024
...otlin/io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeSqlGenerator.kt
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/08-06-snowflake-sqlgen-cleanup
branch
from
368fd1d to
efc745e
Compare
octavia-squidington-iii
added
the
area/documentation
gisripa
force-pushed
the
gireesh/08-06-snowflake-sqlgen-cleanup
branch
from
efc745e to
a18933f
Compare
2 tasks
LouisAuneau
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cleaning up
SnowflakeSqlGenerator.ktby replacingapache.commons.text.StringSubstitutorwith Kotlin's native String interpolation. There is a lot of duplication of code snippets but did not touch it in this PR to minimize diffs. Cannot remove theapache.commons.textdependency in gradle yet since it is still used inSnowflakeDestinationHandler.ktHow
Review guide
No functional or query changes. Any diffs should be solely nuking
StringSubtitutorreferences and replacing with Kotlin's string interpolation and simplifying String concatenation from collections into Kotlin idiomsUser Impact
None. Zero. Zilch.
Can this PR be safely reverted and rolled back?