[file-based cdk] add excel file type support #43346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxi297
reviewed
Aug 7, 2024
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/file_types/test_excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/file_types/test_excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/scenarios/excel_scenarios.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/file_types/test_excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/in_memory_files_source.py
Show resolved
Hide resolved
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Outdated
Show resolved
Hide resolved
girarda
reviewed
Aug 7, 2024
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/excel_parser.py
Show resolved
Hide resolved
girarda
approved these changes
Aug 10, 2024
|
/approve-regression-tests
|
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for excel file formats to the file-based CDK, enabling other connectors to benefit from this enhancement. The implementation includes reading excel files, handling multiple sheets, and schema detection.
How
Add excel format, excel parser and tests
User Impact
No
Can this PR be safely reverted and rolled back?