🐛 Source Shopify: fix customer journey summary field schema type

[bazarnov]

What

While running CAT, the missing schema type for the customer_journey_summary field is missing it's schema type.
It should be the ["null," "object"] type declared.

Shopify Doc

How

• added ["null", "object"] as a type for the customer_journey_summary field in the Customer Journey Summary stream

User Impact

No impact is expected, not a breaking change.

Can this PR be safely reverted and rolled back?

• YES 💚
• NO ❌

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Aug 6, 2024 4:26pm

[maxi297]

Can you provide more context on these questions of mine?

[maxi297]

Does that mean that the customer_order_index was not nested enough? Does that also mean that those fields are empty in the destination right now as we populate customer_journey_summary. customer_order_index instead of customer_order_index?

The same question applies to the other fields like first_visit

[bazarnov]

It was not nested under the properties - yes, but originally it was nested correctly under the customer_journey_summary object, as expected.

I don't think so; no one has asked questions yet, we have had this for 2 months, and I assume the destination_v2 handles the Mapping without type declared correctly for us.

[maxi297]

Oh! I got confused by the indentation. So we assume here the if there are fields under a property that does not have properties, than the platform use those fields as properties? Or does the platform ignore nested fields?

Like, on master we have this:

    "customer_journey_summary": {
      "ready": {
        "description": "Whether the attributed sessions for the order have been created yet.",
        "type": ["null", "boolean"]
      },

Either the platform assume customer_journey_summary to be an object and does not clean the nested fields in customer_journey_summary or the platform just doesn't even consider the nested fields as customer_journey_summary is an object. Does that make sense to you?

[bazarnov]

So we assume here the if there are fields under a property that does not have properties, than the platform use those fields as properties? Or does the platform ignore nested fields?

This should be done by the destination v2, which should treat the non-typed object as an object that has something, thus it's pushed to the destination as an json-string, I believe, instead of the serialized object.

[maxi297]

Approving even with the pending question as we can assume that we would have had customer complaints if this was an issue

[bazarnov]

/approve-regression-tests

Check job output.

✅ Approving regression tests