Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-plausible new config setting for self hosted plausible instance. #43048

Merged
merged 5 commits into from
Aug 6, 2024
Merged

source-plausible new config setting for self hosted plausible instance. #43048

merged 5 commits into from
Aug 6, 2024

Conversation

maxmckenzie
Copy link
Contributor

What

New config added to manifest.yaml for api_url as Plausible can be self hosted.

How

Updated the manifest.yaml

User Impact

  • What is the end result perceived by the user?: they will be given a new config option for API URL

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Aug 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 5:35am

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 3, 2024 07:15 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 3, 2024 07:15 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 3, 2024 07:29 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 3, 2024 07:29 — with GitHub Actions Inactive
marcosmarxm
marcosmarxm requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the connector version in the metadata and pyprojet files (in the connector folder). Also, add the changelog entry in the connector docs and update the setup as it now has a new parameter possible to configure.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 6, 2024
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 6, 2024 05:21 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 6, 2024 05:21 — with GitHub Actions Inactive
@maxmckenzie
Copy link
Contributor Author

Can you bump the connector version in the metadata and pyprojet files (in the connector folder). Also, add the changelog entry in the connector docs and update the setup as it now has a new parameter possible to configure.

Sorted, there where no set up steps so i've added them 💃

@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 6, 2024 05:27 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie temporarily deployed to community-ci-auto August 6, 2024 05:27 — with GitHub Actions Inactive
@maxmckenzie maxmckenzie requested a review from marcosmarxm August 6, 2024 05:31
marcosmarxm
marcosmarxm approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxmckenzie

@marcosmarxm marcosmarxm merged commit bc01248 into airbytehq:master Aug 6, 2024
34 checks passed
maxmckenzie added a commit to maxmckenzie/hub that referenced this pull request Aug 19, 2024
@maxmckenzie
Update airbyte.yml
5d51daf 
Added additional config setting for API URL see airbytehq/airbyte#43048 for more info
@maxmckenzie maxmckenzie mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/plausible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxmckenzie @CLAassistant @marcosmarxm @octavia-squidington-iii