fix(python-cdk): Ensure at least one element returned by decoder #43043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
artem1205
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
LGTM!
This solution is preferable since there are other places where decoder is used.
strosek
approved these changes
Aug 3, 2024
|
CATs for shopify are failing but the error is the same as the ones on master in the previous days and should be fixed with #42973. The Hence, we will merge this change even with the red in the CI. |
|
/approve-regression-tests
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Another proposition for #43018
This P1 shows a bug where if the response is an empty list, this line will break with a stop iteration. The interface is not meant to raise a
StopIterationerror and the user should always expect to have at least one answer. This is my hypothesis based on this case hence, we will perform the same behavior on empty lists.How
If the response is an empty list, return a generator that will have only one empty dictionary
User Impact
This should fix the P1 issue.
Can this PR be safely reverted and rolled back?