feat(connector-insights): track manifest usage of $parameters and custom component classes #43036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
/format-fix
|
natikgadzhi
deleted the
ng/airbyte-ci/connector-insights/custom-component-lists
branch
alafanechere
reviewed
Aug 9, 2024
| @@ -23,6 +23,19 @@ | |||
| from connector_ops.utils import Connector # type: ignore | |||
|
|
|||
|
|
|||
| def get_manifest_inferred_insights(connector: Connector) -> dict: | |||
| manifest = connector.manifest_path.read_text() | |||
There was a problem hiding this comment.
@natikgadzhi this raises a FileNotFounderror on connectors without manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
manifest_uses_parameters,manifest_uses_custom_components, andmanifest_custom_component_classestoconnector_insights.With this information, we will have more data in Migration Tracker dashboard on how to approach manifest-only migration.
Context
find . -name "manifest.yaml" -type f | xargs grep -l "class_name:" > manifests-with-custom-components.txtUser Impact
None, dev tool change.
Next steps
Once this change lands, we need to regenerate insights, and then bring them to airbyte-warehouse.