Skip to content

Github adjustments #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Bug report
about: Report a bug to help us improve
title: ''
labels: bug

---
## Expected Behavior
*Tell us what should happen*

## Current Behavior
*Tell us what happens instead of the expected behavior*

## Steps to Reproduce
1.
1.
1.

## Additional context
*Environment, version, integration...*
12 changes: 12 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
name: Feature request
about: Suggest an idea for Dataline
title: ''
labels: enhancement

---
## Describe the solution you'd like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing 👍


## Describe alternatives you've considered

## Additional context
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
## Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this template have:

  1. What problem is this change solving? (if there is an issue, link to it and no need to describe)
  2. What's the solution being applied?
  3. How should I read the files in this change/which are the most important ones?

I definitely don't want it to be heavyweight but I find that I often have to reverse engineer all these things from the flat code/files which, if there is more than 1 reviewer, can be a time drain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops merge too quickly. Will add that tmw


*Please add screenshots if it affects the frontend. Thank you.*

## Checklist

- [ ] *Create config API model*
- [ ] *Implement config persistence*
- [ ] *Add persistence tests*
38 changes: 29 additions & 9 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Conduit CI
name: Dataline CI

on: push

Expand All @@ -8,13 +8,33 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout Conduit
uses: actions/checkout@v2
- name: Checkout Dataline
uses: actions/checkout@v2

- name: Set up JDK 14
uses: actions/setup-java@v1
with:
java-version: 14
# Impact is fairly limited, might actually need to cache node_modules
- name: Cache node modules
uses: actions/cache@v2
with:
path: ~/.npm
key: npm-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
npm-

- name: Build with Gradle
run: ./gradlew build --no-daemon
- name: Cache java deps
uses: actions/cache@v2
with:
path: ~/.gradle/caches
key: gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: |
gradle-

- name: Set up JDK 14
uses: actions/setup-java@v1
with:
java-version: 14

- name: Build with Gradle
run: ./gradlew build --no-daemon

- name: Ensure no file change
run: git diff-index --quiet HEAD