Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add plain-text info #42967

Merged
merged 5 commits into from
Aug 6, 2024
Merged

docs: Add plain-text info #42967

merged 5 commits into from
Aug 6, 2024

Conversation

nataliekwong
Copy link
Contributor

@nataliekwong nataliekwong commented Aug 2, 2024

What

How

Screenshot 2024-08-02 at 5 10 14 PM

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 6:06pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 2, 2024
@nataliekwong nataliekwong changed the title Add plain-text info docs; Add plain-text info Aug 2, 2024
@nataliekwong nataliekwong changed the title docs; Add plain-text info docs: Add plain-text info Aug 2, 2024
@marcosmarxm
Copy link
Member

Are we going to add a note in Quickstart too>?

@nataliekwong
Copy link
Contributor Author

Can you remind me where you wanted that and what the verbiage you want there? I couldn't find a good place for that just by scanning is this morning.

@marcosmarxm
Copy link
Member

:::tip When you're ready to put an Airbyte instance into production, you'll want to review our guides on deployment.
For the best experience, we recommend Deploying Airbyte on Kubernetes via Helm. :::

:::tip

When you're ready to put an Airbyte instance into production, you'll want to review our guides on deployment.

For the best experience, we recommend Deploying Airbyte on Kubernetes via Helm.

Airbyte's default behavior is to store connector secrets in your configured database. These secrets are stored in plain text and are not encrypted. Please refer to the Secret Management documentation to set up an external secret manager.

:::

What do you do think?

@nataliekwong
Copy link
Contributor Author

@marcosmarxm how's this?
Screenshot 2024-08-05 at 8 18 51 PM

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nataliekwong nataliekwong merged commit ca97b2f into master Aug 6, 2024
30 checks passed
@nataliekwong nataliekwong deleted the natalie/secrets-adj branch August 6, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants