metadata-service [orchestrator]: improve stale metadata detection #42962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
from
6537e9b to
cbeab52
Compare
Base automatically changed from
augustin/08-02-metadata-service_orchestrator_fix_unit_tests
to
master
August 2, 2024 23:17
alafanechere
force-pushed
the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
2 times, most recently
from
44186a8 to
6cf4490
Compare
alafanechere
force-pushed
the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
from
6cf4490 to
259a837
Compare
alafanechere
force-pushed
the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
from
259a837 to
5f21fc9
Compare
natikgadzhi
approved these changes
Aug 8, 2024
| @@ -189,7 +189,7 @@ | |||
| ), | |||
| ScheduleDefinition(job=generate_connector_test_summary_reports, cron_schedule="@hourly"), | |||
| ScheduleDefinition( | |||
| cron_schedule="0 8 * * *", # Daily at 8am US/Pacific | |||
| cron_schedule="0 * * * *", # Every hour | |||
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "orchestrator" | |||
| version = "0.1.4" | |||
| version = "0.1.5" | |||
There was a problem hiding this comment.
Nit: That's prob a 0.2 at least in my book.
There was a problem hiding this comment.
I consider it's a fix of something which was working before, this is why I made a patch bump.
| @@ -130,7 +130,7 @@ def metadata_definitions(context: OpExecutionContext) -> List[LatestMetadataEntr | |||
| metadata_entry = LatestMetadataEntry( | |||
| metadata_definition=metadata_def, | |||
| icon_url=icon_url, | |||
| last_modified=blob.last_modified, | |||
| last_modified=blob.updated.isoformat(), | |||
There was a problem hiding this comment.
Curious, non-blocking: is this for formatting purposes mostly here?
There was a problem hiding this comment.
the LastMetadataEntry.last_modified attribute takes a string - I did not bother changing it to a datetime.
| latest_versions_on_gcs = { | ||
| metadata_entry.metadata_definition.data.dockerRepository: metadata_entry.metadata_definition.data.dockerImageTag | ||
| for metadata_entry in metadata_definitions | ||
| if metadata_entry.metadata_definition.data.supportLevel != "archived" |
There was a problem hiding this comment.
Nice touch with archived connectors.
alafanechere
force-pushed
the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
from
5f21fc9 to
71e2ef6
Compare
alafanechere
deleted the
augustin/08-02-metadata-service_orchestrator_improve_stale_metadata_detection
branch
LouisAuneau
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes to https://github.com/airbytehq/airbyte-internal-issues/issues/8985
Problem
Since the orchestrator now adds generated field to metadata file the MD5 hash / etag comparison of
mastervsGCSdoes not work anymore.Solution
masterbranchdockerImageTagon GCS is different from what we have onmasterfor more than 2 hours.Other changes
The daily frequency (and no message on success) of the stale metadata detection jobs give the false impression that it's not working.
I'd like to increase its frequency (hourly) and make it send a message to a slack even when no stale metadata was detected. This will make sure we have reassuring ping that this alerting is working.