Update metadata.yaml for all sources with sandbox connections #42577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
natikgadzhi
approved these changes
Jul 27, 2024
| @@ -35,6 +35,10 @@ data: | |||
| # This connector is not enabled for OSS/Cloud | |||
| # | |||
| # connectorTestSuitesOptions: | |||
| # - suite: liveTests | |||
There was a problem hiding this comment.
Intentionally keeping this commented for now?
There was a problem hiding this comment.
Yes, the sandbox connection isn't passing check and it has low usage.
alafanechere
suggested changes
Jul 29, 2024
There was a problem hiding this comment.
You have to update the metadata.yaml model to declare a new enum value for suite and declare the connectionOptions property.
Changes have to be made here
|
Thanks @alafanechere I made those changes. |
clnoll
force-pushed
the
catherine/add-connection-ids-to-metadata.yaml
branch
from
cbed420 to
d284219
Compare
clnoll
force-pushed
the
catherine/add-connection-ids-to-metadata.yaml
branch
from
d284219 to
7d2c152
Compare
There was a problem hiding this comment.
@clnoll I'll 👍 when we'll get passing QA checks on connectors, which will mean that metadata with the news fields are valid.
clnoll
force-pushed
the
catherine/add-connection-ids-to-metadata.yaml
branch
5 times, most recently
from
321f246 to
3f1cf83
Compare
|
/approve-regression-tests
|
clnoll
force-pushed
the
catherine/add-connection-ids-to-metadata.yaml
branch
from
3f1cf83 to
e4a82d3
Compare
clnoll
force-pushed
the
catherine/add-connection-ids-to-metadata.yaml
branch
from
e4a82d3 to
4f8cbda
Compare
BenGalewsky
pushed a commit
to BenGalewsky/airbyte
that referenced
this pull request
Aug 4, 2024
jtruty
pushed a commit
to jtruty/airbyte
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add test configuration info for live tests to metadata.yaml for all connections for which there is a sandbox connection in the integration-test-sandboxes workspace.
This will be used in #42574 to automatically run live tests on PRs against sandbox accounts.
With #42574 and #42860, closes #42465.