-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add airbyte-ci command: migrate-to-manifest-only #42576
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/strip/commands.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/strip/commands.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/strip/pipeline.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/strip/pipeline.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/strip/pipeline.py
Outdated
Show resolved
Hide resolved
/format-fix
|
…risto/airbyte-ci-strip-base-image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the versions, and merge this, I don't want the code to sit for too long.
Make a follow-up PR (or a commit in this one) that parses the manifest and detects if $parameters
are there and stops.
Other than that, we can run the wave.
@natikgadzhi Hey, just coming back from the long weekend! Heard on the pypi tagging, I'll add logic to disable the tag and get this merged 👍 |
… pypi flag in metadata
/format-fix
|
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_manifest_only/utils.py
Outdated
Show resolved
Hide resolved
…s/migrate_to_manifest_only/utils.py
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_manifest_only/utils.py
Outdated
Show resolved
Hide resolved
…s/migrate_to_manifest_only/utils.py
/format-fix
|
Using this to migrate source-hibob and source-northpass-lms that got merged yesterday ;) |
What
This PR adds a new airbyte-ci command:
migrate-to-manifest-only
. This command converts a valid low-code connector to manifest-only. It does not accept any additional arguments.Resolves #8849
How
The command is broken up into three distinct steps:
manifest-only
manifest.yaml
,run.py
,__init__.py
andsource.py
YamlDeclarativeSource
streams
method (ie, it is not a hybrid low-code/Python connector)If any of these checks fail, the migration is safely skipped
manifest.yaml
to the root level of the directorymanifest.yaml
manifest.yaml
,metadata.yaml
,icon.svg
, and any valid acceptance/integration test files)language:manifest-only
tag to the connector's metadata and points to the latestsource-declarative-manifest
base imageREADME.md
fileIf a failure occurs during the actual migration, the command will revert any changes to the connector's directory.
Can this PR be safely reverted and rolled back?