Destination snowflake: pull in cdk update for refreshes bugfix #42505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 24, 2024
2 tasks
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
d59f5d8 to
3d9cf10
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
77b72fe to
b985ca0
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
3d9cf10 to
341ae0d
Compare
This was referenced Jul 26, 2024
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
341ae0d to
8a53e44
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
b985ca0 to
f5a8432
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
8a53e44 to
3922cf7
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
f5a8432 to
4ae80f3
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
3922cf7 to
b9bf10d
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
4ae80f3 to
5ff87eb
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
2 times, most recently
from
087b55b to
7fdef81
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
5ff87eb to
789e96e
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
2 times, most recently
from
ad24e27 to
1d5f768
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
1d5f768 to
dd2e935
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
789e96e to
c5f785b
Compare
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
from
dd2e935 to
707b94d
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
c5f785b to
1498c42
Compare
edgao
changed the base branch from
edgao/refreshes_recover_from_real_raw_table
to
edgao/more_refresh_tests
edgao
force-pushed
the
edgao/more_refresh_tests
branch
from
19305f5 to
23a01c7
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
5 times, most recently
from
9154766 to
a84bd37
Compare
edgao
force-pushed
the
edgao/more_refresh_tests
branch
from
23a01c7 to
5fb7304
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
3 times, most recently
from
0e80ea3 to
445f5cc
Compare
edgao
commented
Aug 16, 2024
| import org.junit.jupiter.api.Test | ||
|
|
||
| private val LOGGER = KotlinLogging.logger {} | ||
|
|
||
| abstract class AbstractSnowflakeTypingDedupingTest : BaseTypingDedupingTest() { | ||
| private var databaseName: String? = null | ||
| private lateinit var databaseName: String |
There was a problem hiding this comment.
switching to lateinit b/c otherwise the compiler complains about databaseName potentially changing values between its assignment on line 53 and its usage in cleanAirbyteInternalTable on 57 >.>
There was a problem hiding this comment.
This spotbugs thing is really confusing when it is ok with lateinit and when it is not (I need to figure out how to logically reason about this)
There was a problem hiding this comment.
I still have no idea why spotbugs yells at everyone else about lateinit, I've never had it happen to me >.>
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
2 times, most recently
from
60aeb76 to
ce6c207
Compare
edgao
force-pushed
the
edgao/more_refresh_tests
branch
from
5fb7304 to
95ac402
Compare
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
ce6c207 to
da85a99
Compare
octavia-squidington-iii
added
area/documentation
gisripa
reviewed
Aug 19, 2024
| @@ -100,7 +100,7 @@ class SnowflakeStorageOperation( | |||
| generationIdNode = | |||
| results.first().get(JavaBaseConstants.COLUMN_NAME_AB_GENERATION_ID.uppercase()) | |||
| } | |||
| return generationIdNode?.asLong() | |||
| return generationIdNode?.asLong() ?: 0 | |||
There was a problem hiding this comment.
Are there any implications at the caller if it is interpreted as 0 instead of null ?
There was a problem hiding this comment.
yes, this is the same fix as #42506 (comment)
(i.e. a record with null gen ID should be treated as gen 0, not as belonging to "current generation")
gisripa
approved these changes
Aug 19, 2024
Base automatically changed from
edgao/more_refresh_tests
to
edgao/refreshes_recover_from_real_raw_table
August 19, 2024 16:27
edgao
force-pushed
the
edgao/refreshes_recover_from_real_raw_table
branch
2 times, most recently
from
7270022 to
840e346
Compare
Base automatically changed from
edgao/refreshes_recover_from_real_raw_table
to
master
August 19, 2024 18:07
edgao
force-pushed
the
edgao/snowflake_refreshes_bugfix
branch
from
da85a99 to
5cfdc8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?