Skip to content

Live/regression tests: add support for selecting from a subset of connections #42044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jul 17, 2024

Add an argument to live tests to select from a subset of connections. Defaults to "sandboxes".

This also wires the option through the related GHAs.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 2:51pm

@clnoll clnoll requested a review from alafanechere July 17, 2024 14:21
@clnoll clnoll force-pushed the catherine/live-tests-internal-connection-option branch from 38bd3fd to f88b8aa Compare July 17, 2024 14:22
@clnoll clnoll force-pushed the catherine/live-tests-internal-connection-option branch from f88b8aa to 79498de Compare July 17, 2024 14:24
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

connection_subset:
description: The subset of connections to select from.
required: true
type: choice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know choice exists, cool!

@clnoll clnoll merged commit 548c16c into master Jul 17, 2024
34 checks passed
@clnoll clnoll deleted the catherine/live-tests-internal-connection-option branch July 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants