airbyte-ci: do the regression test status check on all PRs #42040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
clnoll
force-pushed
the
catherine/fix-status-check
branch
2 times, most recently
from
22a1ae2 to
8edbca1
Compare
clnoll
force-pushed
the
catherine/fix-status-check
branch
from
8edbca1 to
0b6b05c
Compare
clnoll
force-pushed
the
catherine/fix-status-check
branch
from
26c696d to
b25dbb3
Compare
| @@ -86,7 +86,7 @@ def do_regression_test_status_check_maybe(ctx: click.Context, status_check_name: | |||
| run_url = ctx.obj["gha_workflow_run_url"] | |||
| should_send = ctx.obj.get("ci_context") == consts.CIContext.PULL_REQUEST | |||
|
|
|||
| if any( | |||
| if is_automerge_pull_request(ctx.obj["pull_request"]) and any( | |||
There was a problem hiding this comment.
Don't we want the opposite behavior: when the pr has the automerge label we want to make the status check pass?
alafanechere
approved these changes
Jul 17, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were skipping the status check
successcall if the PR had no connector changes, but we should always send it.Also sends
successif the PR is marked for auto-merge.