Implement Workspace and Source* API endpoints #42
Conversation
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
well this feels dorky. not sure if i should just throw it in its own module. 🤷♀️
There was a problem hiding this comment.
the is the default workspace that will ship with the app. in a world where there is one workspace, we can just set it up with some default values.
the data dir is where i plan to save configs for now until i figure out how to work with whatever mount point is configured.
| @@ -0,0 +1,6 @@ | |||
| { | |||
|
|
||
| // persist | ||
| final UUID sourceImplementationId = UUID.randomUUID(); | ||
| final SourceConnectionImplementation sourceConnectionImplementation = |
There was a problem hiding this comment.
Is google style forcing 80 columns? I wonder if we could make that larger so we don't have code with so many linebreaks
There was a problem hiding this comment.
yeah. i was trying to see if we could configure googleJavaFormat but i haven't figured that out. i kinda think the idea is that this is how google does it, so you take it or leave it.
dataline-server/src/main/java/io/dataline/server/handlers/SourceImplementationsHandler.java
Outdated
Show resolved
Hide resolved
dataline-server/src/main/java/io/dataline/server/handlers/SourceImplementationsHandler.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private static SourceSpecificationRead standardSourceToSourceRead( | ||
| SourceConnectionSpecification sourceConnectionSpecification) { |
There was a problem hiding this comment.
don't hesitate to use shorter args name
dataline-server/src/main/java/io/dataline/server/handlers/SourceSpecificationsHandler.java
Outdated
Show resolved
Hide resolved
dataline-server/src/main/java/io/dataline/server/apis/ConfigurationApi.java
Outdated
Show resolved
Hide resolved
dataline-server/src/main/java/io/dataline/server/handlers/WorkspacesHandler.java
Outdated
Show resolved
Hide resolved
cgardens
force-pushed
the
charles/first_endpoints2
branch
from
5717004 to
a37efed
Compare
Takes a first pass at implementing endpoints for the Workspace, Source, SourceSpecification, SourceImplementation resources. This informed a lot of the other more infrastructure-y PRs I just put up.
Of note...