Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(source-mixpanel): migrate to CDK v3 #41969

Merged
merged 36 commits into from
Aug 14, 2024
Merged

refactor(source-mixpanel): migrate to CDK v3 #41969

merged 36 commits into from
Aug 14, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jul 15, 2024 •
edited
Loading

What

migrate to CDK v3;
Fix https://github.com/airbytehq/airbyte-internal-issues/issues/8387

How

migrate:

  • def backoff_time -> def get_backoff_strategy
  • def should_retry -> def get_error_handler

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 9:04pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel labels Jul 15, 2024
@lazebnyi
Copy link
Collaborator Author

regression tests - https://github.com/airbytehq/airbyte/actions/runs/9947855021

@brianjlai brianjlai mentioned this pull request Jul 16, 2024
Closed
2 tasks
brianjlai
brianjlai reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some initial comments, will continue reviewing some of the custom components and error handlers, but wanted to first discuss the large amount of ignore mypy statements.

I think that at best, there are some places where we can fix the actual mypy issues instead of ignoring them (see one of my comments below), and at worst, we need to include more comments on the annotations to explain why we have to ignore the type check

@lazebnyi lazebnyi requested a review from brianjlai July 17, 2024 15:49
@lazebnyi
Copy link
Collaborator Author

@brianjlai We had a discussion with @girarda and decided that, since mypy checks are not required for connectors, we can skip fixing those issues and focus only on changes related to error handling.

brianjlai
brianjlai reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments about how we're structuring the custom components, but I think this is very close

@lazebnyi lazebnyi requested review from brianjlai and artem1205 July 29, 2024 18:53
@lazebnyi lazebnyi requested a review from pnilan July 30, 2024 21:17
brianjlai
brianjlai approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thanks for making the changes asked. But since regression tests were last run 2 weeks ago, can you kick off one more regression test run before merging?

@pnilan
Copy link
Contributor

pnilan commented Aug 13, 2024

@lazebnyi Hey where does this PR stand? Looks like it should be ready to merge after resolving conflicts?

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 14, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@lazebnyi
Copy link
Collaborator Author

regression tests - https://github.com/airbytehq/airbyte/actions/runs/10390977148

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 14, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@lazebnyi lazebnyi merged commit a7a9688 into master Aug 14, 2024
35 of 36 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/source-mixpanel-bump-CDK-3.5.0 branch August 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnilan pnilan pnilan approved these changes

@artem1205 artem1205 artem1205 approved these changes

@brianjlai brianjlai brianjlai approved these changes

@girarda girarda Awaiting requested review from girarda

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lazebnyi @pnilan @artem1205 @brianjlai @octavia-squidington-iii