airbyte-ci: add and adopt AIRBYTE_GITHUB_REPO env var #41642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
postamar
force-pushed
the
postamar/airbyte-ci-more-enterprise-fixes
branch
from
6209114 to
ae88e8a
Compare
postamar
changed the title
postamar
force-pushed
the
postamar/airbyte-ci-more-enterprise-fixes
branch
from
ae88e8a to
34bc0f3
Compare
bnchrch
approved these changes
Jul 11, 2024
| @@ -50,7 +52,7 @@ def should_run(self) -> bool: | |||
|
|
|||
| @property | |||
| def github_master_metadata_url(self) -> str: | |||
| return f"{self.GITHUB_URL_PREFIX_FOR_CONNECTORS}/{self.context.connector.technical_name}/{METADATA_FILE_NAME}" | |||
There was a problem hiding this comment.
This -> The removal of self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This env var makes it possible to run airbyte-ci for a repo that's not airbytehq/airbyte.
How
Replaces all hardcoded instances of "airbytehq/airbyte".
User Impact
None
Can this PR be safely reverted and rolled back?