Skip to content

refactor[source-snapchat-marketing]: migrate to low-code #39507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lazebnyi
Copy link
Collaborator

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/8283

How

We have migrated streams to a low-code platform. However, the analytics streams remain in Python, as the low-code implementation requires custom logic for slicing, parsing records, and mapping records that were sliced into fields by chunks.

Review guide

  1. manifest.yaml
  2. source.py

User Impact

Format of state has changed for all connectors as they use per partition state

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:09pm

lazebnyi added 2 commits June 15, 2024 01:41
…ode' of github.com:airbytehq/airbyte into lazebnyi/8283-source-snapchat-marketing-migrate-to-lowcode
lazebnyi added 3 commits June 18, 2024 23:12
…ode' of github.com:airbytehq/airbyte into lazebnyi/8283-source-snapchat-marketing-migrate-to-lowcode
@lazebnyi lazebnyi requested a review from girarda June 19, 2024 16:50
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazebnyi do you know why the acceptance test is failing? The failure is different than the one I see on the nightly build

@lazebnyi
Copy link
Collaborator Author

@lazebnyi do you know why the acceptance test is failing? The failure is different than the one I see on the nightly build

@girarda just a small typo. I have fixed it already.

@lazebnyi lazebnyi requested a review from girarda June 20, 2024 12:54
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! :shipit:

@octavia-squidington-iv octavia-squidington-iv requested a review from a team June 25, 2024 04:17
@lazebnyi lazebnyi merged commit d0b76e9 into master Jul 1, 2024
31 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/8283-source-snapchat-marketing-migrate-to-lowcode branch July 1, 2024 23:10
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snapchat-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants