Skip to content

add uninstall event to run-ab-platform #38627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

colesnodgrass
Copy link
Member

What

  • add uninstall telemetry event to run-ab-platform.sh
    • this event will only be sent if docker compose was successful in bringing up the platform and then the user terminated the platform

How

  • change the NOOP that previously occurred when ctrl+c was detected (after a successful installation) into a new uninstall telemetry event

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@colesnodgrass colesnodgrass requested review from perangel and bgroff May 23, 2024 17:42
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:13pm

@colesnodgrass colesnodgrass requested a review from perangel May 28, 2024 18:03
@colesnodgrass colesnodgrass enabled auto-merge (squash) May 28, 2024 20:15
@colesnodgrass colesnodgrass merged commit 82f8e99 into master May 28, 2024
25 checks passed
@colesnodgrass colesnodgrass deleted the cole/add-uninstall-event branch May 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants