Skip to content

fix(source-zendesk-support): migrate to cursor based pagination #38607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024
Merged

fix(source-zendesk-support): migrate to cursor based pagination #38607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb9cd25
Source Zendesk Support: migrate to cursor based pagination
artem1205 May 23, 2024
3a78d6e
Source Zendesk Support: bump version
artem1205 May 23, 2024
5abc4a8
Source Zendesk Support: add docs
artem1205 May 23, 2024
b15545e
Source Zendesk Support: fmt
artem1205 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
dockerImageTag: 2.6.4
dockerImageTag: 2.6.5
dockerRepository: airbyte/source-zendesk-support
documentationUrl: https://docs.airbyte.com/integrations/sources/zendesk-support
githubIssueLabel: source-zendesk-support
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "2.6.4"
version = "2.6.5"
name = "source-zendesk-support"
description = "Source implementation for Zendesk Support."
authors = [ "Airbyte <[email protected]>",]
Expand Down
4 changes: 4 additions & 0 deletions airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,10 @@ definitions:

organization_memberships_stream:
$ref: "#/definitions/semi_incremental_stream"
retriever:
$ref: "#/definitions/semi_incremental_stream/retriever"
paginator:
$ref: "#/definitions/links_next_paginator"
$parameters:
name: "organization_memberships"
path: "organization_memberships"
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import calendar
import copy
import logging
import re
from datetime import datetime
from unittest.mock import Mock, patch
Expand All @@ -15,7 +16,6 @@
import pytest
import pytz
import requests
from airbyte_cdk import AirbyteLogger
from airbyte_protocol.models import SyncMode
from source_zendesk_support.source import BasicApiTokenAuthenticator, SourceZendeskSupport
from source_zendesk_support.streams import (
Expand Down Expand Up @@ -175,7 +175,7 @@ def test_check(response, start_date, check_passed):
config = copy.deepcopy(TEST_CONFIG)
config["start_date"] = start_date
with patch.object(UserSettingsStream, "get_settings", return_value=response) as mock_method:
ok, _ = SourceZendeskSupport().check_connection(logger=AirbyteLogger, config=config)
ok, _ = SourceZendeskSupport().check_connection(logger=logging.Logger, config=config)
assert check_passed == ok
if ok:
mock_method.assert_called()
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/zendesk-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ The Zendesk Support source connector supports the following streams:
The Zendesk Support connector fetches deleted records in the following streams:

| Stream | Deletion indicator field |
| :----------------------- | :----------------------- |
|:-------------------------|:-------------------------|
| **Brands** | `is_deleted` |
| **Groups** | `deleted` |
| **Organizations** | `deleted_at` |
Expand Down Expand Up @@ -164,6 +164,7 @@ The Zendesk connector ideally should not run into Zendesk API limitations under

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 2.6.5 | 2024-05-23 | [38607](https://github.com/airbytehq/airbyte/pull/38607) | migrate to cursor based pagination in stream `Organization memberships` |
| 2.6.4 | 2024-05-20 | [38310](https://github.com/airbytehq/airbyte/pull/38310) | Fix record filter for `Ticket Metrics` stream |
| 2.6.3 | 2024-05-02 | [36669](https://github.com/airbytehq/airbyte/pull/36669) | Schema descriptions |
| 2.6.2 | 2024-02-05 | [37761](https://github.com/airbytehq/airbyte/pull/37761) | Add stop condition for `Ticket Audits` when recieved old records; Ignore 403 and 404 status codes. |
Expand Down
Loading