Skip to content

Source Snapchat Marketing: update authenticator package #38574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented May 22, 2024

What

Replaces the deprecated authenticator with the updated requests_native_auth implementation.

How

  • Removed the custom SnapchatOauth2Authenticator that was functionally the same as the current CDK implementation.
  • Bumped CDK version to 0.90.0

Review guide

  1. source.py

User Impact

No impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:58pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 22, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review May 22, 2024 19:18
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChristoGrab ChristoGrab merged commit aef0fc7 into master May 23, 2024
31 checks passed
@ChristoGrab ChristoGrab deleted the christo/snapchat/auth branch May 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snapchat-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants