community-ci: run CI on internal packages #38565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
commented
May 22, 2024
| @@ -46,25 +46,13 @@ jobs: | |||
| run-tests: | |||
| needs: changes | |||
| # We only run the Internal Poetry packages CI job if there are changes to the packages on a non-forked PR | |||
| if: needs.changes.outputs.internal_poetry_packages == 'true' | |||
| if: needs.changes.outputs.internal_poetry_packages == 'true' && github.event.pull_request.head.repo.fork != true | |||
There was a problem hiding this comment.
Both workflow declare a job named Internal Poetry packages CI. This is the name of the required check.
This change is to skip the Internal Poetry packages CI we have on internal PRs so that it does not fail the check.
The Internal Poetry packages CI job from the community_ci workflow will run and emit the right check output.
alafanechere
force-pushed
the
augustin/05-22-community-ci_run_CI_on_internal_packages
branch
from
c65515f to
edd2ee6
Compare
alafanechere
force-pushed
the
augustin/05-22-community-ci_run_CI_on_internal_packages
branch
from
edd2ee6 to
d6c66bb
Compare
natikgadzhi
approved these changes
May 22, 2024
alafanechere
added
1-stream~1-table
alafanechere
deleted the
augustin/05-22-community-ci_run_CI_on_internal_packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This introduces a new job in the community ci workflow to run tests on our internal packages from external contributions.
CI execution remains gated by human approval via Github environments.