Destination Snowflake: cleaning up unused code paths #38553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
gisripa
changed the title
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
from
a3d34bc to
217c373
Compare
gisripa
commented
May 22, 2024
...lake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java
Outdated
Show resolved
Hide resolved
edgao
approved these changes
May 22, 2024
| // verify if user has permission to make SQL INSERT queries | ||
| try { | ||
| if (attemptInsert) { | ||
| sqlOps.insertRecords( |
There was a problem hiding this comment.
sigh. snowflake shouldn't even be using this method. fine for now, but eventually we should have snowflake do the actual internal stage + COPY thing for check
...lake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java
Outdated
Show resolved
Hide resolved
| @@ -361,4 +362,9 @@ private String toJdbcTypeName(final AirbyteProtocolType airbyteProtocolType) { | |||
| }; | |||
| } | |||
|
|
|||
| @Override | |||
| public void createNamespaces(@NotNull Set<String> schemas) { | |||
|
|
|||
There was a problem hiding this comment.
nit: is it safe to throw new UnsupportedOperationException("not yet implemented")? (just to be explicit that this should be implemented, we just haven't gotten around to it yet
There was a problem hiding this comment.
yeah was planning to add that. just to be sure it doesn't get called erroneously.
...wflake/src/main/kotlin/io/airbyte/integrations/destination/snowflake/SnowflakeDestination.kt
Outdated
Show resolved
Hide resolved
...ke/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
4 times, most recently
from
e67a86e to
41fd326
Compare
2 tasks
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
from
41fd326 to
ba3d8fc
Compare
gisripa
force-pushed
the
gireesh/cdk-cleanup-snowflake
branch
from
71b6cba to
3ac8c86
Compare
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
from
ba3d8fc to
e3601d8
Compare
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
from
e3601d8 to
1eb280e
Compare
octavia-squidington-iii
added
the
area/documentation
2 tasks
gisripa
force-pushed
the
gireesh/05-21-snowflake-clean-unused
branch
from
1eb280e to
429ce3a
Compare
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove remnants of
SwitchingDestinationand decouple Snowflake fromAbstractJdbcDestinationbase implementation (nothing is reused except a check related function)User Impact
Can this PR be safely reverted and rolled back?