Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix Arcade sizing in docs #38472

Merged
merged 1 commit into from
May 21, 2024
Merged

docs: Fix Arcade sizing in docs #38472

merged 1 commit into from
May 21, 2024

Conversation

timroes
Copy link
Contributor

@timroes timroes commented May 21, 2024

What

Allow specifying the padding-bottom property of the wrapping div for an arcade which is needed to calculate the correct size and is different for each arcade.

This can be found in the Share menu when looking at the arcade in their portal:

2024-05-21_16-22

Paste that code somewhere, and it will contain the padding-bottom that needs to be copied, e.g. the pasted snippet looks like:

<div style="position: relative; padding-bottom: calc(56.73828125% + 41px); height: 0; width: 100%;"><iframe src="https://demo.arcade.software/4V0TGOX02P0rwVNwz4MR?embed&show_copy_link=true&variable.first_name=INSERT_VALUE_HERE&variable.company_name=INSERT_VALUE_HERE" title="Getting Started (Source)" frameborder="0" loading="lazy" webkitallowfullscreen mozallowfullscreen allowfullscreen allow="clipboard-write" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;color-scheme: light;"></iframe></div>

In this case the paddingBottom property of our doc's Arcade component must be set to calc(56.73828125% + 41px), which can be found in the style property of the div.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@timroes timroes requested a review from nataliekwong May 21, 2024 14:23
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:25pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 21, 2024
@timroes timroes changed the title Fix Arcade sizing in docs docs: Fix Arcade sizing in docs May 21, 2024
@timroes timroes merged commit 4aad08f into master May 21, 2024
26 checks passed
@timroes timroes deleted the tim/fix-arcade-sizing branch May 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants