-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Shopify: add missing fields to the Products
stream
#38464
🎉 Source Shopify: add missing fields to the Products
stream
#38464
Conversation
…ify/add-missing-products-fields
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the fields are all included in the response, one small nit but otherwise all LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ify/add-missing-products-fields
What
Resolving:
How
products
query to include the missing fieldsproducts
stream schema to include the missing fieldsunit_test
case to cover the changesUser Impact
No impact is expected, but the
reset
is recommended in order to pick up the schema changes and have the target fields.Can this PR be safely reverted and rolled back?