Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: add missing fields to the Products stream #38464

Merged
merged 7 commits into from
May 23, 2024

Conversation

bazarnov
Copy link
Collaborator

What

Resolving:

How

  • extended the products query to include the missing fields
  • extended the products stream schema to include the missing fields
  • added processing for them (unnest is required for some of them)
  • edited unit_test case to cover the changes

User Impact

No impact is expected, but the reset is recommended in order to pick up the schema changes and have the target fields.

Can this PR be safely reverted and rolled back?

  • YES 💚

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 10:56am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 21, 2024
@bazarnov bazarnov marked this pull request as ready for review May 21, 2024 12:25
@bazarnov bazarnov requested a review from a team May 21, 2024 12:25
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 21, 2024
Copy link
Contributor

@ChristoGrab ChristoGrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the fields are all included in the response, one small nit but otherwise all LGTM!

Copy link
Contributor

@cmm-airbyte cmm-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bazarnov bazarnov merged commit 07c0584 into master May 23, 2024
32 checks passed
@bazarnov bazarnov deleted the baz/baz/source/shopify/add-missing-products-fields branch May 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify team/critical-connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants