Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: add TypeTransformer to Tickets stream #38286

Merged
merged 3 commits into from
May 16, 2024

Conversation

bazarnov
Copy link
Collaborator

What

Having this issue:

There is an issue with the Hubspot source. The nightly tests failed because the contacts in the tickets stream are of the wrong type. The expected type is an integer, but we are getting a string for our test account.

How

  • added TypeTransformer with default schema normalization to ensure the declared data types, declared in stream schema

User Impact

No impact is expected.

Can this PR be safely reverted and rolled back?

  • YES 💚

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 2:39pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 16, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 16, 2024
@bazarnov bazarnov marked this pull request as ready for review May 16, 2024 14:13
@bazarnov bazarnov requested a review from a team May 16, 2024 14:13
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something in the HubSpot documentation saying the string will represent an integer? Are there release notes mentioning this change? Should we contact them about this change?

@bazarnov
Copy link
Collaborator Author

@bazarnov bazarnov merged commit 73a44d0 into master May 16, 2024
33 checks passed
@bazarnov bazarnov deleted the baz/source/hubspot/add-type-transformer-to-tickets branch May 16, 2024 17:29
@aljets
Copy link

aljets commented May 24, 2024

Did this change somehow revert 4.1.3 somehow? I'm not seeing contacts_list_memberships as incremental with 4.1.4, only 4.1.3

Not sure how to chalk this up to user error, but it definitely was showing as an option in 4.1.3 and not in 4.1.4. Now it is showing agian...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot team/critical-connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants