File-based CDK: avoid error on empty stream when running discover #38230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
lazebnyi
requested changes
May 16, 2024
airbyte-cdk/python/airbyte_cdk/sources/file_based/file_based_source.py
Outdated
Show resolved
Hide resolved
lazebnyi
approved these changes
May 16, 2024
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of fix for https://github.com/airbytehq/product-request-backlog/issues/138
How
Return default
schemaless_schemainstead of raisingNoFilesMatchingErrorexception when empty stream is found duringdiscoverReview guide
default_file_based_stream.pyUser Impact
No
Can this PR be safely reverted and rolled back?