Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Pinecone: Add source_tag for attribution + unit tests #38151

Merged
merged 13 commits into from
May 15, 2024
Merged

Destination Pinecone: Add source_tag for attribution + unit tests #38151

merged 13 commits into from
May 15, 2024

Conversation

bindipankhudi
Copy link
Contributor

@bindipankhudi bindipankhudi commented May 12, 2024 •
edited
Loading

Related tickets:

Changes in this PR:

  • Pass a new param source_tag when initializing PineconeGRPC module. Tag is set to "airbyte" by default. For integration tests, tag is set to "airbyte_tests". Documentation for reference.
  • Unrelated to above: Added unit tests to bring test coverage to 90%

@bindipankhudi bindipankhudi requested a review from a team as a code owner May 12, 2024 20:09
@vercel Vercel
Copy link

vercel bot commented May 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 1:22am

@bindipankhudi bindipankhudi removed the request for review from a team May 12, 2024 20:09
@bindipankhudi bindipankhudi changed the title Destination Pinecone: Increase unit test coverage to fix nightly build errors (WIP) Destination Pinecone: Add source_tag for attribution May 13, 2024
@bindipankhudi bindipankhudi changed the title Destination Pinecone: Add source_tag for attribution Destination Pinecone: Add source_tag for attribution + some unit tests May 13, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 13, 2024
@bindipankhudi bindipankhudi changed the title Destination Pinecone: Add source_tag for attribution + some unit tests Destination Pinecone: Add source_tag for attribution + unit tests May 13, 2024
@bindipankhudi bindipankhudi requested a review from aaronsteers May 13, 2024 23:00
aaronsteers
aaronsteers requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. One suggestion - which is totally optional - but I think we can use a built-in env var Rather than declaring a new one. This should be slightly more stable since new tests will also automatically have this set.

One additional issue I'm seeing now is that CAT tests don't rely on PyTest, and we should try to account for them as well.

Can we check if CAT and/or airbyte-ci set an enrollment variable which we can detect?

bindipankhudi and others added 5 commits May 14, 2024 11:47
@bindipankhudi
Copy link
Contributor Author

This is great. One suggestion - which is totally optional - but I think we can use a built-in env var Rather than declaring a new one. This should be slightly more stable since new tests will also automatically have this set.

One additional issue I'm seeing now is that CAT tests don't rely on PyTest, and we should try to account for them as well.

Can we check if CAT and/or airbyte-ci set an enrollment variable which we can detect?

  • Added the built in pytest env variable
  • Added check for CI

@bindipankhudi bindipankhudi requested a review from aaronsteers May 15, 2024 01:39
@bindipankhudi
Copy link
Contributor Author

@aaronsteers, addressed the review feedback. We are using built-in pytest env variable now, and also checking the CI env variable.

aaronsteers
aaronsteers approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🚀🎉

@bindipankhudi bindipankhudi merged commit 1c3a6c4 into master May 15, 2024
34 checks passed
@bindipankhudi bindipankhudi deleted the bindi/destination-pinecone-test-coverage branch May 15, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/pinecone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bindipankhudi @aaronsteers @octavia-squidington-iii