Skip to content

Destination dev null: support dedup #38118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2024
Merged

Destination dev null: support dedup #38118

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e34e6c
also fix dev null
edgao May 10, 2024
c34e500
changelog
edgao May 10, 2024
bb409eb
blegh
edgao May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-dev-null/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: file
connectorType: destination
definitionId: a7bcc9d8-13b3-4e49-b80d-d020b90045e3
dockerImageTag: 0.3.2
dockerImageTag: 0.3.3
dockerRepository: airbyte/destination-dev-null
githubIssueLabel: destination-dev-null
icon: airbyte.svg
Expand Down
14 changes: 12 additions & 2 deletions ...n/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,18 @@
}

@Override
public void testSyncNotFailsWithNewFields() {
// Skip because `retrieveRecords` returns an empty list at all times.
// Skip because `retrieveRecords` returns an empty list at all times.
@Disabled

Check failure on line 63 in airbyte-integrations/connectors/destination-dev-null/src/test-integration/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java

View workflow job for this annotation

GitHub Actions / Gradle Check 

[Task :airbyte-integrations:connectors:destination-dev-null:compileIntegrationTestJavaJava FAILED] cannot find symbol
  @disabled
   ^
  symbol:   class Disabled
@Test

Check failure on line 64 in airbyte-integrations/connectors/destination-dev-null/src/test-integration/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java

View workflow job for this annotation

GitHub Actions / Gradle Check 

[Task :airbyte-integrations:connectors:destination-dev-null:compileIntegrationTestJavaJava FAILED] cannot find symbol
  @test
   ^
  symbol:   class Test
public void testSyncNotFailsWithNewFields() {}

@Override
// This test assumes that dedup support means normalization support.
// Override it to do nothing.
@Disabled

Check failure on line 70 in airbyte-integrations/connectors/destination-dev-null/src/test-integration/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java

View workflow job for this annotation

GitHub Actions / Gradle Check 

[Task :airbyte-integrations:connectors:destination-dev-null:compileIntegrationTestJavaJava FAILED] cannot find symbol
  @disabled
   ^
  symbol:   class Disabled
@Test

Check failure on line 71 in airbyte-integrations/connectors/destination-dev-null/src/test-integration/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java

View workflow job for this annotation

GitHub Actions / Gradle Check 

[Task :airbyte-integrations:connectors:destination-dev-null:compileIntegrationTestJavaJava FAILED] cannot find symbol
  @test
   ^
  symbol:   class Test
public void testIncrementalDedupeSync() throws Exception {
super.testIncrementalDedupeSync();
}

}
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-dev-null/src/test/resources/expected_spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"supportsIncremental": true,
"supportsNormalization": false,
"supportsDBT": false,
"supported_destination_sync_modes": ["overwrite", "append"],
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
"protocol_version": "0.2.1",
"connectionSpecification": {
"$schema": "http://json-schema.org/draft-07/schema#",
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/dev-null.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The Airbyte `dev-null` Destination. This destination is for testing and debuggin

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :---------------- |
| 0.3.3 | 2023-05-08 | [38118](https://github.com/airbytehq/airbyte/pull/38118) | Support dedup |
| 0.3.2 | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Support Refreshes |
| 0.3.0 | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Change Schema |
| 0.2.7 | 2022-08-08 | [13932](https://github.com/airbytehq/airbyte/pull/13932) | Bump version |
Loading