Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Amazon Seller Partner: hide OSS-only streams in report options config #38078

Merged
merged 3 commits into from
May 9, 2024

Conversation

askarpets
Copy link
Contributor

@askarpets askarpets commented May 9, 2024

What

OSS-only streams need to be hidden in report options config section when running on cloud

How

Deleted OSS-only stream names from spec.json and dynamically added for OSS customers

Review guide

  1. source.py
  2. spec.json
  3. amazon-seller-partner.md
  4. test_source.py

User Impact

No

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@askarpets askarpets self-assigned this May 9, 2024
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:07am

@askarpets askarpets merged commit 1e79e92 into master May 9, 2024
34 checks passed
@askarpets askarpets deleted the source-amazon-seller-partner-update-spec branch May 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants