Skip to content

[chore] Format __init__.py files #38044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[chore] Format __init__.py files #38044

wants to merge 6 commits into from

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented May 7, 2024 •
edited
Loading

What

Now that #38043 is up, this PR is removing flakeCheck for the Python CDK temporarily, and formats __init__.py files.

We will add linters back when we migrate to Ruff (working on it this week). This step allows us to move forward and not have weird splitbrain formatting situation.

Also, closes https://github.com/airbytehq/airbyte-internal-issues/issues/2773!

Review

Easiest to review commit by commit — all actual formatting is in one commit, then there's another one that removes flakecheck from pyproject.toml.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@natikgadzhi natikgadzhi requested review from alafanechere, aaronsteers and a team May 7, 2024 18:49
@natikgadzhi natikgadzhi requested a review from a team May 7, 2024 18:49
@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:23pm

@natikgadzhi natikgadzhi changed the title Ng/python format init py [chore] Format __init__.py files May 7, 2024
@natikgadzhi
Copy link
Contributor Author

BRB adding licenses.

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented May 7, 2024 •
edited by github-actions bot
Loading

/format-fix pr=38044

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented May 7, 2024 •
edited
Loading

🟦 Job completed successfully (no changes).

But in the re-ran CI flow:

license: Finished running formatter - Failed

I need help. This is extremely weird — locally and in format-fix, there are no changes. But the CI flow does reformat several licences in init.py.

I'd think perhaps that's because it uses master version of the ignore settings, but then it should not do that locally.

I've deleted EVERYTHING from my docker and tried re-running, but I somehow nuked the whole thing and airbyte-ci just hangs without output locally, dagger container not even running.

I'll try again tomorrow. 1am my time here. Three PRs stuck on this.

@natikgadzhi
Copy link
Contributor Author

Interestingly, looking at the failures, they are legit. The mentioned files don't have license header on them. Let me install the tool and run it locally without airbyte-ci to see if it helps.

@natikgadzhi natikgadzhi requested a review from a team May 7, 2024 22:23
@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented May 7, 2024 •
edited by github-actions bot
Loading

/format-fix pr=38044

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@natikgadzhi natikgadzhi closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere Awaiting requested review from alafanechere

@aaronsteers aaronsteers Awaiting requested review from aaronsteers

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@oustynova oustynova Awaiting requested review from oustynova

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/aws-datalake connectors/destination/chroma connectors/destination/qdrant connectors/destination/vectara connectors/source/alpha-vantage connectors/source/amazon-ads connectors/source/amazon-seller-partner connectors/source/amplitude connectors/source/appsflyer connectors/source/asana connectors/source/aws-cloudtrail connectors/source/bamboo-hr connectors/source/bing-ads connectors/source/braze connectors/source/cart connectors/source/chargebee connectors/source/close-com connectors/source/declarative-manifest connectors/source/delighted connectors/source/facebook-marketing connectors/source/facebook-pages connectors/source/file connectors/source/freshdesk connectors/source/github connectors/source/gitlab connectors/source/google-drive connectors/source/google-search-console connectors/source/google-sheets connectors/source/harvest connectors/source/hubspot connectors/source/instagram connectors/source/intercom connectors/source/iterable connectors/source/jira connectors/source/linkedin-ads connectors/source/looker connectors/source/mailchimp connectors/source/marketo connectors/source/metabase connectors/source/mixpanel connectors/source/monday connectors/source/recharge connectors/source/recurly connectors/source/salesforce connectors/source/sendgrid connectors/source/shopify connectors/source/slack connectors/source/smartsheets connectors/source/snapchat-marketing connectors/source/square connectors/source/stripe connectors/source/surveymonkey connectors/source/tempo connectors/source/tiktok-marketing connectors/source/tplcentral connectors/source/twilio connectors/source/us-census connectors/source/zendesk-chat connectors/source/zendesk-support connectors/source/zoho-crm normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natikgadzhi @octavia-squidington-iii