Regression tests: display stdout/stderr even if there was an exception before the report could be created. #38008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
clnoll
force-pushed
the
regression-tests-handle-dagger-exception
branch
from
5ce0d7a to
8d11352
Compare
before the report could be created.
clnoll
force-pushed
the
regression-tests-handle-dagger-exception
branch
from
8d11352 to
a8ce766
Compare
alafanechere
approved these changes
May 7, 2024
Comment on lines
421
to
429
| exit_code, stdout, stderr = await get_exec_result(container) | ||
|
|
||
| with open(path_to_report, "r") as fp: | ||
| regression_test_report = fp.read() | ||
| try: | ||
| await container.file(path_to_report).export(path_to_report) | ||
| with open(path_to_report, "r") as fp: | ||
| regression_test_report = fp.read() | ||
| except Exception as exc: | ||
| main_logger.exception(f"Could not export or read report due to exception. traceback={traceback.format_exc()}", exc_info=exc) | ||
| regression_test_report = None |
There was a problem hiding this comment.
Just summarizing my understanding of the flow.
get_exec_resultactually executes the command in the container- If there's an
ExecErrorduring the execution of this command we get stdout and stderr from the exception object - If an
ExecErrorwas thrown (and handled) executingcontainer.file()will likely fail as we're trying to get a file that does not exist.
Instead of excepting a broad exception I'd be in favor of being more specific:
if "report.html" not in await container.directory(f"{regression_tests_artifacts_dir}/session_{self.run_id}").entries():
main_logger.exception("The report file was not generated, an unhandled error likely happened during regression test execution, please check the step stderr and stdout for more details")
else:
await container.file(path_to_report).export(path_to_report)
with open(path_to_report, "r") as fp:
regression_test_report = fp.read()There was a problem hiding this comment.
I like the suggestion, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there's an exception running regression tests before the report is written, we get a generic exception that the report couldn't be exported from the container because it does not exist.
However, this causes us to not be able to see the stderr/stdout.
This code change makes a small modification so to handle the exception exporting the report so we can still see the stderr/stdout of the container.