-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): add cdk version #37809
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is to power docs I'd appreciate a dedicated docs
field or a cdk_version
top level field.
I'm concerned about introducing a dependencies
field which just has the CDK ATM. I'd prefer dependencies
to contain all dependencies, and find a language agnostic way of expressing them.
So I'd be fine with both or either one of these approaches:
- Add all connectors dependencies to
dependencies
(basically copying the information available in these files - Add a
doc
specific field to the registry entry which would show the CDK version (after searching it from thedependencies
field or directly fromdependencies.json
).
Fair point! What are your thoughts on cdk_version as a top level field? or moving |
Happy to move |
Im thinking we avoid adding
So I wanted to ask you is there a top level field we could use to contain this that:
? |
9d7c6c2
to
2c8909d
Compare
b1ce5ab
to
8399b2f
Compare
2c8909d
to
654f28d
Compare
8399b2f
to
9428bc5
Compare
654f28d
to
926ee78
Compare
9428bc5
to
26ab522
Compare
What
Adds the cdk version for python connectors to the regisry
closes https://github.com/airbytehq/airbyte-internal-issues/issues/7462