Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add cdk version #37809

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 3, 2024

What

Adds the cdk version for python connectors to the regisry

Screenshot 2024-05-03 at 3.00.59 PM.png

closes https://github.com/airbytehq/airbyte-internal-issues/issues/7462

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 2:46pm

Copy link
Contributor Author

bnchrch commented May 3, 2024

@bnchrch bnchrch requested a review from alafanechere May 3, 2024 22:01
@bnchrch bnchrch marked this pull request as ready for review May 3, 2024 22:01
@bnchrch bnchrch requested a review from a team May 3, 2024 22:01
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to power docs I'd appreciate a dedicated docs field or a cdk_version top level field.
I'm concerned about introducing a dependencies field which just has the CDK ATM. I'd prefer dependencies to contain all dependencies, and find a language agnostic way of expressing them.
So I'd be fine with both or either one of these approaches:

  • Add all connectors dependencies to dependencies (basically copying the information available in these files
  • Add a doc specific field to the registry entry which would show the CDK version (after searching it from the dependencies field or directly from dependencies.json).

@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 6, 2024 09:35
Copy link
Contributor Author

bnchrch commented May 6, 2024

Fair point!

What are your thoughts on cdk_version as a top level field?

or moving cdk_version under generated?

@alafanechere
Copy link
Contributor

Fair point!

What are your thoughts on cdk_version as a top level field?

or moving cdk_version under generated?

Happy to move cdk_version to a top level field and find a way to tell if it's the python or java cdk version.
Could be two, mutually exclusive, top level fields: python_cdk_version, java_cdk_version

Copy link
Contributor Author

bnchrch commented May 7, 2024

Im thinking we avoid adding cdk_version to the top level of the registry for the following reasons:

  1. Not all connectors will have a CDK version
  2. If we keep adding info like this to the top level it will get messy

So I wanted to ask you is there a top level field we could use to contain this that:

  1. Would make sense to put cdk_version under
  2. Would not be prescriptive to where its used/consumed? (This was why I wasnt immediately happy with docs)
  3. We likely would put future fields under

?

@bnchrch bnchrch requested a review from alafanechere May 7, 2024 19:21
@bnchrch bnchrch force-pushed the bnchrch/registry/add-provience-metadata branch from 9d7c6c2 to 2c8909d Compare May 7, 2024 19:22
@bnchrch bnchrch force-pushed the 05-03-feat_registry_add_cdk_version branch from b1ce5ab to 8399b2f Compare May 7, 2024 19:22
@bnchrch bnchrch force-pushed the bnchrch/registry/add-provience-metadata branch from 2c8909d to 654f28d Compare May 8, 2024 21:34
@bnchrch bnchrch force-pushed the 05-03-feat_registry_add_cdk_version branch from 8399b2f to 9428bc5 Compare May 8, 2024 21:34
Copy link
Contributor Author

bnchrch commented May 9, 2024

Merge activity

  • May 9, 10:18 AM EDT: @bnchrch started a stack merge that includes this pull request via Graphite.
  • May 9, 10:46 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 11:02 AM EDT: @bnchrch merged this pull request with Graphite.

@bnchrch bnchrch force-pushed the bnchrch/registry/add-provience-metadata branch from 654f28d to 926ee78 Compare May 9, 2024 14:29
Base automatically changed from bnchrch/registry/add-provience-metadata to master May 9, 2024 14:45
@bnchrch bnchrch force-pushed the 05-03-feat_registry_add_cdk_version branch from 9428bc5 to 26ab522 Compare May 9, 2024 14:45
@bnchrch bnchrch merged commit 2b97e6d into master May 9, 2024
32 checks passed
@bnchrch bnchrch deleted the 05-03-feat_registry_add_cdk_version branch May 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants