✨ Source Salesforce: Adding bulk stream mock server tests #37749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
maxi297
changed the title
maxi297
commented
May 1, 2024
| @@ -179,31 +179,6 @@ def test_stream_contains_unsupported_properties_by_bulk(stream_config, stream_ap | |||
| assert not isinstance(stream, BulkSalesforceStream) | |||
|
|
|||
|
|
|||
| def test_bulk_sync_pagination(stream_config, stream_api, requests_mock): | |||
There was a problem hiding this comment.
Moved to test_given_locator_when_read_then_extract_records_from_both_pages
maxi297
commented
May 1, 2024
| assert output.get_stream_statuses(_STREAM_NAME)[-1] == AirbyteStreamStatus.COMPLETE | ||
|
|
||
| def test_given_non_retryable_error_on_delete_job_result_when_read_then_fail_to_sync(self): | ||
| """ |
There was a problem hiding this comment.
I don't think we've seen errors for that in prod but it would be sad kill the stream because of that
bazarnov
reviewed
May 2, 2024
airbyte-integrations/connectors/source-salesforce/unit_tests/integration/test_bulk_stream.py
Outdated
Show resolved
Hide resolved
bazarnov
approved these changes
May 2, 2024
cmm-airbyte
reviewed
May 2, 2024
airbyte-integrations/connectors/source-salesforce/unit_tests/integration/test_bulk_stream.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-salesforce/unit_tests/integration/test_bulk_stream.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-salesforce/unit_tests/integration/test_bulk_stream.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-salesforce/unit_tests/integration/test_bulk_stream.py
Show resolved
Hide resolved
ChristoGrab
reviewed
May 3, 2024
airbyte-integrations/connectors/source-salesforce/unit_tests/salesforce_job_response_builder.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Before integrating the HttpClient that @pnilan is working on, we want to add a good safety need to identify issues without having to test manually before and after.
How
Adding mock server tests
User Impact
No customer impact. However, developer won't have to test manually before and after to ensure the behavior is the same.
Can this PR be safely reverted and rolled back?