airbyte-ci format: make most inputs optional in run-airbyte-ci #37683
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/04-30-airbyte-ci_format_make_most_inputs_optional_in_run-airbyte-ci
branch
11 times, most recently
from
ece3999 to
755156d
Compare
| @@ -36,8 +36,10 @@ runs: | |||
| if [[ "${{ github.ref }}" != "refs/heads/master" ]] && [[ "${{ steps.changes.outputs.pipelines_any_changed }}" == "true" ]]; then | |||
| echo "Making changes to Airbyte CI on a non-master branch. Airbyte-CI will be installed from source." | |||
| echo "install-mode=source" >> $GITHUB_OUTPUT | |||
| echo "SENTRY_ENVIRONMENT=dev" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
I moved this here because I figure it was not properly declared in run-airbyte-ci. It make more sense to declare this env var here:
When we're developing on airbyte-ci we don't want to create noise in sentry so we set the sentry env to dev.
When we're using airbyte-ci binary (not developing on it) we want to set the sentry env to prod.
| @@ -93,15 +93,14 @@ runs: | |||
| - name: Get start timestamp | |||
| id: get-start-timestamp | |||
| shell: bash | |||
| run: echo "name=start-timestamp=$(date +%s)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
name= was a typo...
There was a problem hiding this comment.
Lol, how did this even work then?
| - name: Docker login | ||
| id: docker-login | ||
| uses: docker/login-action@v3 | ||
| if: ${{ inputs.docker_hub_username != '' && inputs.docker_hub_password != '' }} |
There was a problem hiding this comment.
Do no perform docker login if no docker creds were passed by the calling workflow
alafanechere
force-pushed
the
augustin/04-30-airbyte-ci_format_make_most_inputs_optional_in_run-airbyte-ci
branch
from
755156d to
698ff69
Compare
alafanechere
force-pushed
the
augustin/04-30-airbyte-ci_format_make_most_inputs_optional_in_run-airbyte-ci
branch
from
698ff69 to
5a55192
Compare
There was a problem hiding this comment.
I think this is already good — and I agree with @aaronsteers, perhaps we should just keep one implementation of format_check that runs on both our PRs and PRs from forks? If there is nothing priviledged, no extra env is needed?
| @@ -93,15 +93,14 @@ runs: | |||
| - name: Get start timestamp | |||
| id: get-start-timestamp | |||
| shell: bash | |||
| run: echo "name=start-timestamp=$(date +%s)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Lol, how did this even work then?
| SLACK_WEBHOOK: ${{ inputs.slack_webhook_url }} | ||
| SPEC_CACHE_BUCKET_NAME: ${{ inputs.spec_cache_bucket_name }} | ||
| SPEC_CACHE_GCS_CREDENTIALS: ${{ inputs.spec_cache_gcs_credentials }} | ||
| # give the Dagger Engine more time to push cache data to Dagger Cloud | ||
| run: | | ||
| airbyte-ci --disable-update-check --disable-dagger-run --is-ci --gha-workflow-run-id=${{ github.run_id }} ${{ inputs.subcommand }} ${{ inputs.options }} |
There was a problem hiding this comment.
TIL there's disable-dagger-run!
| if: always() | ||
| uses: jwalton/gh-docker-logs@v2 | ||
| with: | ||
| dest: "./docker_logs" | ||
| dest: "./dagger_engine_logs" |
There was a problem hiding this comment.
This is essentially just a rename of the output file, right? Still same / similar logs?
| # IMPORTANT: This name must match the require check name on the branch protection settings | ||
| name: "Check for formatting errors" | ||
| if: github.event.pull_request.head.repo.fork == true | ||
| environment: community-ci-auto |
There was a problem hiding this comment.
Does this make it "gated" by a human button press? Do we care?
alafanechere
deleted the
augustin/04-30-airbyte-ci_format_make_most_inputs_optional_in_run-airbyte-ci
branch
What
Continue to make
formatautomatically run on fork but clean up the work introduced in #37356 to use the consistent approach in installing and running airbyte-ci via therun-airbyte-cire-usable action.How
format_check.ymlworkflowformatjob in thecommunity_ci.ymlworkflow. Make it run automatically in a newcommmunity-ci-autoenvironmnet.run-airbyte-ciinputs optional to avoid requiring secret passing in format.