CI: Skip airbyte-ci version check in format_check, already a fresh binary install
#37642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
aaronsteers
changed the title
airbyte-ci version check in format_check, already a fresh binary install
natikgadzhi
approved these changes
Apr 26, 2024
|
Oh, hello automerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Skip version check on CI format check.
This resolves an issue where checks immediately fail when a new version of
airbyte-cibecomes available.The problem is that the CLi is newer than what is on the branch.
Since the execution of
airbyte-cicomes from the binary download, and because it does not depend on the local branch being up to date, we should not fail the check because the running version (binary download) is newer than the local branch version (not used anyway).Lmk if I'm missing anything here.
Example PR affected by this now:
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?