Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(live-test): Update Copy Button style #37632

Merged
merged 1 commit into from
Apr 29, 2024
Merged

style(live-test): Update Copy Button style #37632

merged 1 commit into from
Apr 29, 2024

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Apr 26, 2024 •
edited
Loading

What changed?

image.png

  1. Restyled the copy to clipboard button
  2. Reordered styles so that it went element > class

Why make this change?

To improve the readability and aesthetics of the report generated by the template.

@bnchrch bnchrch requested review from alafanechere and clnoll April 26, 2024 17:00
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 5:00pm

@bnchrch Graphite App
Copy link
Contributor Author

bnchrch commented Apr 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bnchrch and the rest of your teammates on Graphite Graphite

This was referenced Apr 26, 2024
Merged
Merged
@bnchrch bnchrch marked this pull request as ready for review April 26, 2024 17:05
@bnchrch bnchrch requested a review from a team April 26, 2024 17:05
clnoll
clnoll approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bnchrch bnchrch merged commit bf82168 into master Apr 29, 2024
34 checks passed
@bnchrch bnchrch deleted the 04-26-style_live-test_update_copy_button_style branch April 29, 2024 15:33
@bnchrch Graphite App
Copy link
Contributor Author

bnchrch commented Apr 29, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clnoll clnoll clnoll approved these changes

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnchrch @clnoll