Skip to content

remove all dependencies to lombok #37627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Apr 26, 2024

We only use lombok for super trivial stuff and it tends to not play well with Micronauts. Lets' get rid of it!

@stephane-airbyte stephane-airbyte marked this pull request as ready for review April 26, 2024 15:20
@stephane-airbyte stephane-airbyte requested review from a team as code owners April 26, 2024 15:20
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 6:52pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 26, 2024
Copy link
Contributor Author

stephane-airbyte commented Apr 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it? That's all we use Lombok for? Let's get rid of it.

@stephane-airbyte stephane-airbyte force-pushed the stephane/04-26-remove_all_dependencies_to_lombok branch from 1d8c045 to b98f5d8 Compare April 26, 2024 18:52
@stephane-airbyte stephane-airbyte merged commit 75ac5a9 into master Apr 26, 2024
31 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-26-remove_all_dependencies_to_lombok branch April 26, 2024 19:01
Copy link
Contributor Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants