Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-ci: make the cdk test fail if they run on forks #37569

Conversation

alafanechere
Copy link
Contributor

We're not allowing community contribution to the CDK. If a changes was made to the CDK on a fork we want to early fail the test workflow to not run untrusted code.

@alafanechere alafanechere requested a review from a team April 25, 2024 09:30
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 9:30am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere merged commit ae022a6 into master Apr 25, 2024
31 checks passed
@alafanechere alafanechere deleted the augustin/04-25-community-ci_make_the_cdk_test_fail_if_they_run_on_forks branch April 25, 2024 09:34
@natikgadzhi
Copy link
Contributor

We're not allowing community contribution to the CDK. If a changes was made to the CDK on a fork we want to early fail the test workflow to not run untrusted code.

@alafanechere wait, why? I don't mind contributions to the CDK at all. Why block them by failing tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants