Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python CDK: remove "deprecated" package #37497

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Python CDK: remove "deprecated" package #37497

merged 2 commits into from
Apr 23, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Apr 23, 2024 •
edited
Loading

What

  • Delete code
  • This code has been under a deprecated folder and untouched for at least 3 years (blame history gets hard to track before that). 🪓 it

User Impact

No one should be using this.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@erohmensing erohmensing requested a review from a team April 23, 2024 02:04
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:12pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 23, 2024
@erohmensing Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @erohmensing and the rest of your teammates on Graphite Graphite

@erohmensing erohmensing requested a review from natikgadzhi April 23, 2024 02:06
natikgadzhi
natikgadzhi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! Let's 🚢.

Did you cmd+f connectors in our repo to see if we are using it anywhere? I'd say even if we are, still shipit.

I've restarted formatters, but I'm honestly cool to merge as is. Formatters died after 10 and a half minutes with a dagger error :lolsob:

@erohmensing erohmensing force-pushed the ella/remove-deprecated branch from 0435838 to f7bf348 Compare April 23, 2024 17:54
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-directory labels Apr 23, 2024
@erohmensing
Copy link
Contributor Author

erohmensing commented Apr 23, 2024 •
edited
Loading

@natikgadzhi thanks, thought i did but apparently just looked at usages. Was only used in one connector, will pin its dependency with a note.

@erohmensing erohmensing force-pushed the ella/remove-deprecated branch from f8fb130 to b7961be Compare April 23, 2024 18:12
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Apr 23, 2024
@erohmensing
Copy link
Contributor Author

/approve-and-merge reason="updating dependency cap of community connector without re-releasing it, no op to connector itself"

@octavia-approvington
Copy link
Contributor

A job well done
nice job

@octavia-approvington octavia-approvington merged commit e766ba3 into master Apr 23, 2024
32 of 34 checks passed
@octavia-approvington octavia-approvington deleted the ella/remove-deprecated branch April 23, 2024 18:23
strosek pushed a commit that referenced this pull request Apr 24, 2024
@erohmensing
Python CDK: remove "deprecated" package (#37497)
c7a03cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/source/google-directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erohmensing @octavia-approvington @natikgadzhi @octavia-squidington-iii