fix kotlin warnings in dependencies CDK submodule #37484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/04-22-fix-kotlin-warnings-in-dependencies
branch
2 times, most recently
from
0893885 to
7737503
Compare
stephane-airbyte
changed the title
stephane-airbyte
force-pushed
the
stephane/04-22-fix-kotlin-warnings-in-dependencies
branch
from
7737503 to
4f26d13
Compare
postamar
reviewed
Apr 23, 2024
...irbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/concurrency/CompletableFutures.kt
Outdated
Show resolved
Hide resolved
postamar
reviewed
Apr 23, 2024
airbyte-cdk/java/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/json/Jsons.kt
Show resolved
Hide resolved
postamar
reviewed
Apr 23, 2024
| // Manually build the stacktrace, excluding the top-level exception object | ||
| // so that we don't accidentally include the exception message. | ||
| // Otherwise we could just do ExceptionUtils.getStackTrace(t). | ||
| var t: Throwable? = t | ||
| var t: Throwable? = throwable |
There was a problem hiding this comment.
t should not exist at all if the function arg is legitimately not nullable
There was a problem hiding this comment.
I actually need a new object, because it's being reassigned line 434. But I can make it non-nullable
postamar
reviewed
Apr 23, 2024
| @@ -90,7 +88,7 @@ object StreamStatusUtils { | |||
| airbyteStream: Optional<AirbyteStreamNameNamespacePair>, | |||
| statusEmitter: Optional<Consumer<AirbyteStreamStatusHolder>> | |||
| ) { | |||
| airbyteStream!!.ifPresent { s: AirbyteStreamNameNamespacePair? -> | |||
| airbyteStream.ifPresent { s: AirbyteStreamNameNamespacePair? -> | |||
There was a problem hiding this comment.
comment applies elsewhere also
There was a problem hiding this comment.
yeah, I didn't go through those as they're not marked as warning. Will need another pass for that :(
postamar
approved these changes
Apr 23, 2024
stephane-airbyte
force-pushed
the
stephane/04-22-fix-kotlin-warnings-in-dependencies
branch
2 times, most recently
from
93bb626 to
d662f7e
Compare
stephane-airbyte
force-pushed
the
stephane/04-22-fix-kotlin-warnings-in-dependencies
branch
from
d662f7e to
8c41168
Compare
stephane-airbyte
deleted the
stephane/04-22-fix-kotlin-warnings-in-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearing kotlin warnings