Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Klaviyo: fix invalid path for '.coveragerc ' #37439

Conversation

jlemmoniw
Copy link
Contributor

Fixes #37438

What

Modifies an invalid path on Windows machines.

How

Removes a space in the file extension.

Review guide

git clone or git checkout on a Windows machine.

User Impact

Should be no perceivable impact.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Was showing "error: invalid path 'airbyte-integrations/connectors/source-klaviyo/.coveragerc '" on checkout.
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 6:13pm

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, was there a trailing whitespace in the filename?

@natikgadzhi
Copy link
Contributor

Oh well. Okay! Thank you @jlemmoniw.

@natikgadzhi natikgadzhi merged commit d497014 into airbytehq:master Apr 20, 2024
9 of 10 checks passed
@jlemmoniw
Copy link
Contributor Author

Yeah, that's all it was @natikgadzhi. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-klaviyo] Checkout error: invalid path 'airbyte-integrations/connectors/source-klaviyo/.coveragerc '
4 participants