Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Analytics v4: fix empty response error #37432

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Apr 19, 2024

What

Resolve https://github.com/airbytehq/oncall/issues/4664

migrate service-account-only version to poetry

How

handle empty response error

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@artem1205 artem1205 self-assigned this Apr 19, 2024
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 5:09pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 19, 2024
@artem1205 artem1205 requested review from erohmensing and a team April 19, 2024 11:43
@artem1205 artem1205 marked this pull request as ready for review April 19, 2024 16:18
@octavia-squidington-iv octavia-squidington-iv requested a review from a team April 19, 2024 16:19
@artem1205
Copy link
Contributor Author

/approve-and-merge reason="source-google-analytics-v4-service-account-only cannot be ported to poetry due to cross-connector dependency"

@octavia-approvington
Copy link
Contributor

It's time
fine lets go

@octavia-approvington octavia-approvington merged commit c05c70b into master Apr 24, 2024
32 of 35 checks passed
@octavia-approvington octavia-approvington deleted the artem1205/source-google-v4-OC-4664 branch April 24, 2024 13:37
strosek pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants