-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Allow format fix on PRs from forks #37393
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@aaronsteers tell me when you'd like a review on this. Looks sane. |
@natikgadzhi - This could be reviewed+merged as-is, but there are two outstanding questions here:
We have code to copy-paste which gives this functionality, but it also makes the PR larger, more surface area to review. UPDATE: I've toggled to 'ready for review' status, in the context of the above two questions. FWIW, I've tested successfully on a couple PRs. (It can be run from the manual workflow dispatch - selecting this branch and then entering any PR number.) |
Let's add this to review bucket with @alafanechere for Tuesday. My expectation is that tomorrow we decide between:
|
Per meeting today, @alafanechere to review. Hopefully merge today or tomorrow 🚀 |
This modified the
format_fix
CI workflow as follows:I also connected to the
/format-fix
slash command, and added feedback comments to the PR being operated on.