Example of a fully concurrent source with GNews #37386
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
maxi297
commented
Apr 18, 2024
| def close(self) -> None: | ||
| self._cursor.close_partition(self) | ||
|
|
||
| def __hash__(self) -> int: |
There was a problem hiding this comment.
We can probably have the default implement in the CDK and relying on to_slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To serve as documentation only (it seems like GNews has very low API rate limit and hence was a very bad pick for concurrency), I've tried to move source-gnews to Concurrent CDK with the new API.
How
By using the airbyte_cdk.sources.streams.concurrent package without relying on the adapters.
Identification of missing parts
Must
DateTimeStreamStateConverterto easy the migration for already existing source but for brand new, it would be nice to have one where the state datetime format does not need to be providedPartition. is_closedas it is not used and hence is confusing as to how it should be implementedNice to have
Can this PR be safely reverted and rolled back?
This PR is not meant the be merged.